This repository was archived by the owner on Oct 2, 2019. It is now read-only.
fix(build): fix sourcemap logic #1541
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
wesleycho
commented
Mar 30, 2016
wesleycho
commented
- Fix sourcemap generation
- Upgrade plugins
- Fix sourcemap generation - Upgrade plugins
|
This LGTM |
| .pipe($.header(config.banner, { | ||
| timestamp: (new Date()).toISOString(), pkg: config.pkg | ||
| })) | ||
| .pipe($.concat('select.css')) | ||
| .pipe(gulp.dest('dist')) |
There was a problem hiding this comment.
@wesleycho I've had to restore this line locally to get select.css saved to dist, are you sure it should have been removed?
There was a problem hiding this comment.
It's not necessary to have sourcemaps unless it's minified, no?
There was a problem hiding this comment.
Yeah I think what you're saying is correct, double negatives and all 👀
We are always minifying though, I think the maps are generated fine but the unminified css isn't saved to dist.
With:
return gulp.src(['src/common.css'], {base: 'src'})
.pipe($.sourcemaps.init())
.pipe($.header(config.banner, {
timestamp: (new Date()).toISOString(), pkg: config.pkg
}))
.pipe($.concat('select.css'))
.pipe(gulp.dest('dist'))
.pipe($.minifyCss())
.pipe($.concat('select.min.css'))
.pipe($.sourcemaps.write('../dist', {debug: true}))
.pipe(gulp.dest('dist'));I get
- select.min.css
- select.min.css.map
- select.min.js
- select.min.js.map
- select.css
- select.js
With:
return gulp.src(['src/common.css'], {base: 'src'})
.pipe($.sourcemaps.init())
.pipe($.header(config.banner, {
timestamp: (new Date()).toISOString(), pkg: config.pkg
}))
.pipe($.concat('select.css'))
//.pipe(gulp.dest('dist'))
.pipe($.minifyCss())
.pipe($.concat('select.min.css'))
.pipe($.sourcemaps.write('../dist', {debug: true}))
.pipe(gulp.dest('dist'));I get:
- select.min.css
- select.min.css.map
- select.min.js
- select.min.js.map
- select.js
Note the missing select.css, easy enough to fix just wanted to be sure I was doing it right.
user378230
added a commit
to user378230/ui-select
that referenced
this pull request
Apr 4, 2016
Resolves bad changes made in angular-ui#1541 which caused no select.css to be generated as part of the build.
user378230
added a commit
that referenced
this pull request
Apr 4, 2016
Resolves bad changes made in #1541 which caused no select.css to be generated as part of the build.
fcaballero
pushed a commit
to fcaballero/ui-select
that referenced
this pull request
Apr 17, 2016
Resolves bad changes made in angular-ui#1541 which caused no select.css to be generated as part of the build.
fcaballero
pushed a commit
to fcaballero/ui-select
that referenced
this pull request
Apr 25, 2016
Resolves bad changes made in angular-ui#1541 which caused no select.css to be generated as part of the build.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.